Skip to content

gh-77328: Update base64 module docstring to reference RFC 4648#151275

Merged
StanFromIreland merged 3 commits into
python:mainfrom
StanFromIreland:4648
Jun 13, 2026
Merged

gh-77328: Update base64 module docstring to reference RFC 4648#151275
StanFromIreland merged 3 commits into
python:mainfrom
StanFromIreland:4648

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 10, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

The docs were fixed, but the docstring was missed.

@StanFromIreland StanFromIreland added the docs Documentation in the Doc dir label Jun 10, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 10, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 10, 2026
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Jun 13, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check also binascii.

@StanFromIreland

StanFromIreland commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

I don't see any other references in binascii that need updating, an overall grep:

$ gg -r "3548" -- ':!Lib/test/*data/*' ':!Misc/svnmap.txt' ':!Modules/cjkcodecs/mappings_*.h' ':!Modules/unicode*_db.h'
Doc/library/subprocess.rst:      `ShowWindow <https://msdn.microsoft.com/en-us/library/ms633548(v=vs.85).aspx>`__
Doc/whatsnew/2.4.rst:* The :mod:`base64` module now has more complete :rfc:`3548` support for Base64,
Lib/base64.py:"""Base16, Base32, Base64 (RFC 3548), Base85 and Ascii85 data encodings"""
Lib/base64.py:# Modified 30-Dec-2003 by Barry Warsaw to add full RFC 3548 support
Lib/base64.py:RFC 3548 allows for optional mapping of the digit 0 (zero) to the
Lib/base64.py:# RFC 3548, Base 16 Alphabet specifies uppercase, but hexlify() returns
Lib/reprlib.py:            # See https://github.com/python/cpython/issues/135487.
Binary file Lib/test/randv2_32.pck matches
Lib/test/test_hashlib.py:                           'a86548c92ccc35480805987cb70be17b'), None),
Misc/HISTORY:- base64 now supports RFC 3548 Base16, Base32, and Base64 encoding and
Misc/NEWS.d/3.12.0b1.rst:.. gh-issue: 103548
Misc/NEWS.d/3.13.0a6.rst:.. gh-issue: 113548
Misc/NEWS.d/3.15.0a1.rst:.. gh-issue: 135489
Misc/NEWS.d/3.15.0a1.rst:.. gh-issue: 135487
Misc/NEWS.d/3.6.6rc1.rst:.. bpo: 33548
Misc/NEWS.d/3.7.0b5.rst:.. bpo: 33548
Misc/NEWS.d/3.8.0a1.rst:.. bpo: 33548
Misc/NEWS.d/3.8.0a1.rst:.. bpo: 35488
Modules/_hacl/internal/Hacl_Hash_SHA2.h:    0x650a73548baf63deULL, 0x766a0abb3c77b2a8ULL, 0x81c2c92e47edaee6ULL, 0x92722c851482353bULL,
Tools/unicode/python-mappings/GB2312.TXT:0x3548 0x7B49  # <CJK>
Tools/unicode/python-mappings/gb-18030-2000.xml:  <a u="3548" b="82 30 91 35"/>
Tools/unicode/python-mappings/jisx0213-2004-std.txt:3-3548      U+5409  # <cjk>

StanFromIreland
StanFromIreland commented Jun 13, 2026
View reviewed changes
Comment thread Lib/base64.py Outdated
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 13, 2026
@StanFromIreland StanFromIreland enabled auto-merge (squash) June 13, 2026 12:00
@StanFromIreland

StanFromIreland commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review Serhiy!

@StanFromIreland StanFromIreland merged commit e933987 into python:main Jun 13, 2026
54 checks passed
@StanFromIreland StanFromIreland deleted the 4648 branch June 13, 2026 12:21
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 13, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 13, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 13, 2026

Copy link
Copy Markdown

GH-151438 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 13, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 13, 2026

Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e9339876883f96af2e406a92a05be647b7fbe5d5 3.13

@bedevere-app

bedevere-app Bot commented Jun 13, 2026

Copy link
Copy Markdown

GH-151439 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 13, 2026
StanFromIreland added a commit that referenced this pull request Jun 13, 2026
@miss-islington @StanFromIreland
[3.15] gh-77328: Update base64 module RFC references to RFC 4648 (G…
5156e8f 
…H-151275) (#151438)

(cherry picked from commit e933987)

Co-authored-by: Stan Ulbrych <stan@python.org>
StanFromIreland added a commit that referenced this pull request Jun 13, 2026
@miss-islington @StanFromIreland
[3.14] gh-77328: Update base64 module RFC references to RFC 4648 (G…
2149a97 
…H-151275) (#151439)

(cherry picked from commit e933987)

Co-authored-by: Stan Ulbrych <stan@python.org>
@bedevere-app

bedevere-app Bot commented Jun 13, 2026

Copy link
Copy Markdown

GH-151441 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 13, 2026
StanFromIreland added a commit that referenced this pull request Jun 13, 2026
@StanFromIreland
[3.13] gh-77328: Update base64 module RFC references to RFC 4648 (G…
9cbbb07 
…H-151275) (#151441)

(cherry picked from commit e933987)
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
@StanFromIreland @philthompson10
pythongh-77328: Update base64 module RFC references to RFC 4648 (py…
e6cd6b6 
…thon#151275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

@StanFromIreland StanFromIreland

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @serhiy-storchaka